Change Tree.t representation to use lazy contents values #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigfe
commented
Feb 5, 2021
craigfe
force-pushed
the
fix--shallow-on-contents
branch
from
fef4b82
to
236f41f
Compare
samoht
reviewed
Feb 5, 2021
samoht
reviewed
Feb 5, 2021
samoht
reviewed
Feb 5, 2021
|
That looks great and simplify quite a few bits of |
Co-authored-by: Thomas Gazagnaire <thomas@gazagnaire.org>
samoht
approved these changes
Feb 5, 2021
craigfe
added a commit
to craigfe/opam-repository
that referenced
this pull request
Feb 16, 2021
… irmin-chunk, irmin-pack, irmin-test, irmin-http, irmin-unix, ppx_irmin, irmin-bench, irmin-graphql, irmin-containers, irmin-mirage-git and irmin-mirage-graphql (2.5.0)
CHANGES:
### Changed
- **irmin**
- `Store.Tree.remove` is now much faster when operating on large directories.
The commits following removals are also much faster. (mirage/irmin#1289, @Ngoguey42)
- Changed `Store.Tree.{of_hash, shallow}` to take kinded hashes, allowing the
creation of unforced contents values. (mirage/irmin#1285, @craigfe)
- Changed `Tree.destruct` to return _lazy_ contents values, which may be forced
with `Tree.Contents.force`. (mirage/irmin#1285, @craigfe)
- **irmin-bench**
- New features in benchmarks for tree operations (mirage/irmin#1269, @Ngoguey42)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the type of trees to support lazy contents values:
This means that contents are (internally) handled symmetrically to nodes: as unforced pointers to values in the underlying stores wherever possible. The user-facing changes are:
Tree.destructreturns unforced contents pointers that can be dereferenced withTree.Contents.force.Tree.of_hashandTree.shallownow take kinded hashes with appropriate metadata.This is motivated by #1284, which stems from the fact that we don't currently support "shallow" tree leaves. With this change, it's easy to extend
Tree.shallowto support this, and I've added @smelc's now-working test case from that issue here. (Thanks!)Fixes #1284.