Tree.remove scaling #1289
Merged
Tree.remove scaling #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ngoguey42
force-pushed
the
tree-remove-scaling
branch
from
2945a75
to
2d5f561
Compare
Co-authored-by: Craig Ferguson <me@craigfe.io>
Ngoguey42
force-pushed
the
tree-remove-scaling
branch
from
bca7958
to
03506ee
Compare
craigfe
approved these changes
Feb 15, 2021
There was a problem hiding this comment.
Looks great, thanks @Ngoguey42. Merge when ready and I'll cut a release.
|
Thanks for the review |
craigfe
added a commit
to craigfe/opam-repository
that referenced
this pull request
Feb 16, 2021
… irmin-chunk, irmin-pack, irmin-test, irmin-http, irmin-unix, ppx_irmin, irmin-bench, irmin-graphql, irmin-containers, irmin-mirage-git and irmin-mirage-graphql (2.5.0)
CHANGES:
### Changed
- **irmin**
- `Store.Tree.remove` is now much faster when operating on large directories.
The commits following removals are also much faster. (mirage/irmin#1289, @Ngoguey42)
- Changed `Store.Tree.{of_hash, shallow}` to take kinded hashes, allowing the
creation of unforced contents values. (mirage/irmin#1285, @craigfe)
- Changed `Tree.destruct` to return _lazy_ contents values, which may be forced
with `Tree.Contents.force`. (mirage/irmin#1285, @craigfe)
- **irmin-bench**
- New features in benchmarks for tree operations (mirage/irmin#1269, @Ngoguey42)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1272
New perfs
Commit it now ~14 times quicker, it is repaired.
Remove is now only ~3 times quicker because of the poor implementation of
Tree.Node.is_empty.Master - flatten
This PR - flatten