Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove irmin-http #1902

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Remove irmin-http #1902

merged 1 commit into from
Aug 1, 2023

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Jun 18, 2022

  • Removes irmin-http since it no longer works with generic key stores
  • irmin-graphql should be the preferred method of interacting with a remote irmin store using high-level operations
  • irmin-server/irmin-client should be used instead of irmin-http for low-level operations. Both irmin-http and irmin-server provide clients that implement Irmin.S, however irmin-server is more optimized and also provides a Batch API that can be used to reduce the number of requests needed to perform an operation.

@zshipko zshipko force-pushed the remove-http branch 2 times, most recently from c9b9fc5 to 827b225 Compare June 23, 2022 23:08
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2022

Codecov Report

Merging #1902 (15a1982) into main (7065c66) will increase coverage by 0.63%.
The diff coverage is n/a.

❗ Current head 15a1982 differs from pull request most recent head b0cb4b7. Consider uploading reports for the commit b0cb4b7 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1902      +/-   ##
==========================================
+ Coverage   68.16%   68.80%   +0.63%     
==========================================
  Files         137      132       -5     
  Lines       16652    16165     -487     
==========================================
- Hits        11351    11122     -229     
+ Misses       5301     5043     -258     
Files Changed Coverage Δ
src/irmin-cli/cli.ml 21.46% <ø> (+0.72%) ⬆️
src/irmin-cli/resolver.ml 54.54% <ø> (+0.90%) ⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zshipko zshipko marked this pull request as ready for review June 24, 2022 18:46
@zshipko zshipko force-pushed the remove-http branch 3 times, most recently from 46da26f to 3da86cc Compare July 5, 2022 22:40
@samoht
Copy link
Member

samoht commented Jul 7, 2022

Will merge this once irmin-server is ready to be integrated

@metanivek
Copy link
Member

@zshipko think we can close this in favor of #2031?

@zshipko
Copy link
Contributor Author

zshipko commented Nov 4, 2022

Hm, yeah this can be closed but there could also be a case to be made for removing irmin-http before irmin-server is integrated since there are still some details to figure out in regards to #2031

@metanivek
Copy link
Member

Got it. As long as these ship together in a release, I'm fine to keep them separate PRs. Could you make #2031 just about adding irmin-server? Then we can keep this PR as the irmin-http removal PR.

@metanivek metanivek mentioned this pull request Feb 20, 2023
2 tasks
@metanivek metanivek self-assigned this Jun 6, 2023
@metanivek metanivek merged commit 020b52e into mirage:main Aug 1, 2023
5 checks passed
art-w added a commit to art-w/opam-repository that referenced this pull request Oct 9, 2023
CHANGES:

### Added

- **irmin-server**
  - Added `irmin-server` package (mirage/irmin#2031, @zshipko)
- **irmin-client**
  - Added `irmin-client` package to connect to `irmin-server` instances (mirage/irmin#2031,
    @zshipko)
- **irmin**
  - Add pretty printers for `Commit`, `Tree`, `Info`, `Status`, `Branch` when
    using `utop` (@metanivek, mirage/irmin#1839)

### Fixed

- **irmin-pack**
  - Fix index integrity check for v3 stores (mirage/irmin#2267, @metanivek)

### Removed

- **irmin-http**
  - Removed `irmin-http` since it is not compatible with generic keys.
    `irmin-grapqhl` or `irmin-server` should be used instead. (mirage/irmin#1902, @zshipko)
- **irmin**
  - Removed stream proofs. We now only have Merkle tree proofs. This simplifies
    the maintenance of that part of the code, as ensuring the correct order of
    cached IO operations was tricky for stream proofs (mirage/irmin#2275, @samoht)

### Changed

- **irmin-git**
  - Moved lower bounds to `git.3.14.0` to use new function (mirage/irmin#2277, @metanivek)
nberth pushed a commit to nberth/opam-repository that referenced this pull request Jun 18, 2024
CHANGES:

### Added

- **irmin-server**
  - Added `irmin-server` package (mirage/irmin#2031, @zshipko)
- **irmin-client**
  - Added `irmin-client` package to connect to `irmin-server` instances (mirage/irmin#2031,
    @zshipko)
- **irmin**
  - Add pretty printers for `Commit`, `Tree`, `Info`, `Status`, `Branch` when
    using `utop` (@metanivek, mirage/irmin#1839)

### Fixed

- **irmin-pack**
  - Fix index integrity check for v3 stores (mirage/irmin#2267, @metanivek)

### Removed

- **irmin-http**
  - Removed `irmin-http` since it is not compatible with generic keys.
    `irmin-grapqhl` or `irmin-server` should be used instead. (mirage/irmin#1902, @zshipko)
- **irmin**
  - Removed stream proofs. We now only have Merkle tree proofs. This simplifies
    the maintenance of that part of the code, as ensuring the correct order of
    cached IO operations was tricky for stream proofs (mirage/irmin#2275, @samoht)

### Changed

- **irmin-git**
  - Moved lower bounds to `git.3.14.0` to use new function (mirage/irmin#2277, @metanivek)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants