-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
irmin-pack: fix index integrity check for v3 #2267
Merged
metanivek
merged 2 commits into
mirage:main
from
metanivek:irmin-pack/fix-integrity-check-index
Aug 1, 2023
Merged
irmin-pack: fix index integrity check for v3 #2267
metanivek
merged 2 commits into
mirage:main
from
metanivek:irmin-pack/fix-integrity-check-index
Aug 1, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
art-w
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! LGTM :)
(edit: but let's wait for the CI to complete before merging ^^)
art-w
added a commit
to art-w/opam-repository
that referenced
this pull request
Oct 9, 2023
CHANGES: ### Added - **irmin-server** - Added `irmin-server` package (mirage/irmin#2031, @zshipko) - **irmin-client** - Added `irmin-client` package to connect to `irmin-server` instances (mirage/irmin#2031, @zshipko) - **irmin** - Add pretty printers for `Commit`, `Tree`, `Info`, `Status`, `Branch` when using `utop` (@metanivek, mirage/irmin#1839) ### Fixed - **irmin-pack** - Fix index integrity check for v3 stores (mirage/irmin#2267, @metanivek) ### Removed - **irmin-http** - Removed `irmin-http` since it is not compatible with generic keys. `irmin-grapqhl` or `irmin-server` should be used instead. (mirage/irmin#1902, @zshipko) - **irmin** - Removed stream proofs. We now only have Merkle tree proofs. This simplifies the maintenance of that part of the code, as ensuring the correct order of cached IO operations was tricky for stream proofs (mirage/irmin#2275, @samoht) ### Changed - **irmin-git** - Moved lower bounds to `git.3.14.0` to use new function (mirage/irmin#2277, @metanivek)
tezoslibrarian
pushed a commit
to tezos/tezos-mirror
that referenced
this pull request
Apr 17, 2024
nberth
pushed a commit
to nberth/opam-repository
that referenced
this pull request
Jun 18, 2024
CHANGES: ### Added - **irmin-server** - Added `irmin-server` package (mirage/irmin#2031, @zshipko) - **irmin-client** - Added `irmin-client` package to connect to `irmin-server` instances (mirage/irmin#2031, @zshipko) - **irmin** - Add pretty printers for `Commit`, `Tree`, `Info`, `Status`, `Branch` when using `utop` (@metanivek, mirage/irmin#1839) ### Fixed - **irmin-pack** - Fix index integrity check for v3 stores (mirage/irmin#2267, @metanivek) ### Removed - **irmin-http** - Removed `irmin-http` since it is not compatible with generic keys. `irmin-grapqhl` or `irmin-server` should be used instead. (mirage/irmin#1902, @zshipko) - **irmin** - Removed stream proofs. We now only have Merkle tree proofs. This simplifies the maintenance of that part of the code, as ensuring the correct order of cached IO operations was tricky for stream proofs (mirage/irmin#2275, @samoht) ### Changed - **irmin-git** - Moved lower bounds to `git.3.14.0` to use new function (mirage/irmin#2277, @metanivek)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few issues existed for running the index integrity check for v3 stores:
I've added more stores to our cram test so that we cover all of these issues.
Fixes #2264