irmin: optimise V1.Hash.encode/decode #2028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2028 +/- ##
=======================================
Coverage 64.53% 64.53%
=======================================
Files 129 129
Lines 15561 15561
=======================================
Hits 10042 10042
Misses 5519 5519 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
metanivek
reviewed
Aug 1, 2022
| encode_bin e f | ||
|
|
||
| let decode_bin buf pos_ref = | ||
| pos_ref := !pos_ref + 8; |
There was a problem hiding this comment.
Where does this 8 (and the one below) come from?
There was a problem hiding this comment.
that's the size to encode in int64
There was a problem hiding this comment.
Do not allocate intermediary strings to encode and decode V1 hashes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not allocate intermediary strings to encode and decode V1 hashes.