Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irmin-pack-tools: Add base58 support for ppidx #2266

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Conversation

clecat
Copy link
Contributor

@clecat clecat commented Jul 26, 2023

Adds the dump of the hashes in base58 alongside the base64 as asked by @art-w

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Merging #2266 (a6d07c5) into main (514e7ba) will decrease coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is 92.00%.

❗ Current head a6d07c5 differs from pull request most recent head 9b7ad61. Consider uploading reports for the commit 9b7ad61 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2266      +/-   ##
==========================================
- Coverage   68.20%   68.19%   -0.01%     
==========================================
  Files         138      138              
  Lines       16739    16739              
==========================================
- Hits        11416    11415       -1     
- Misses       5323     5324       +1     
Files Changed Coverage Δ
src/irmin-pack/inode.ml 79.43% <90.47%> (ø)
src/irmin-pack/pack_value.ml 86.81% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@clecat clecat added the no-changelog-needed No changelog is needed here label Jul 27, 2023
Copy link
Member

@metanivek metanivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm happy with the simplified solution!

src/irmin-pack-tools/ppidx/dune Outdated Show resolved Hide resolved
@metanivek metanivek merged commit c03a74b into mirage:main Aug 1, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-needed No changelog is needed here
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants