Tree: improved complexity. #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a trivial benchmark (initialising a tree with a lot of values), this patch introduces a 20-times speed-up (around 60 seconds to around 3). This is achieved by removing unrequired structural comparisons when inserting/removing a value in the tree. The function `add/add_tree/remove` try to reduce the pressure on the GC by not reallocating the tree when the resulting tree is (structurally) equal to the previous one. But instead of only comparing the inserted value to the previous value (if it exists), the current implementation also recursively compare all the nodes on the insertion path. This patch simplify the insertion/removal, by changing the type of the recursive function `aux`. It now returns an option : `None` when the sub tree was not modified.
|
Thanks a lot! Something I've been wondering with the tree structure is if we should always prune the empty directories or not. For the Git backend it makes sense (because Git will do it anyway) but maybe there are some use-cases where we are interested in distinguishing empty directories. This could be controlled by an optional argument to What do you think? |
ghost
mentioned this pull request
|
I have no particular usage in mind where preserving empty directories would be useful. But if so, the optional argument looks fine. |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a trivial benchmark (initialising a tree with a lot of values), this
patch introduces a 10-times speed-up (around 30 seconds to around 3).
This is achieved by removing unrequired structural comparisons when
inserting/removing a value in the tree.
The function
add/add_tree/removetry to reduce the pressure on the GCby not reallocating the tree when the resulting tree is (structurally)
equal to the previous one. But instead of only comparing the inserted
value to the previous value (if it exists), the current implementation
also recursively compare all the nodes on the insertion path.
This patch simplify the insertion/removal, by changing the type of the
recursive function
aux. It now returns an option :Nonewhen the subtree was not modified.