Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add a function to extract the parameter list. #5

Merged
merged 3 commits into from
Jul 29, 2015
Merged

Conversation

Drup
Copy link
Member

@Drup Drup commented Jul 20, 2015

I was going to add iter and fold, and realize it was just better to export the list.
The internal representation is not exposed, so you still have the liberty to change it.

I also improved a bit the documentation and removed a layer of exception handler.

NB: The xen backend doesn't work for me at the moment, so It's basically untested. No travis on this repository. :(

@Drup Drup changed the title Add a function to extrat the parameter list. Add a function to extract the parameter list. Jul 20, 2015
@Drup
Copy link
Member Author

Drup commented Jul 20, 2015

Woops, I managed to miss #4 ...

@mor1
Copy link
Member

mor1 commented Jul 20, 2015

Re Xen-- what's not working? Have you tried http://github.com/mirage/mirage-vagrant-vms? (What platform do you develop on?)

@Drup
Copy link
Member Author

Drup commented Jul 20, 2015

Just patiently waiting for mirage/mirage-platform#138 ;)

@MagnusS
Copy link
Member

MagnusS commented Jul 23, 2015

Thanks! It's a bit different as it exposes the parameters directly while #4 adds argv so they can be parsed with Cmdliner. Perhaps useful to have both? @nojb

@Drup
Copy link
Member Author

Drup commented Jul 23, 2015

I think it would be nice to have both, yes, but anyway, as @nojb was saying, it should be integrated in mirage-plateform.

@MagnusS
Copy link
Member

MagnusS commented Jul 29, 2015

Yes, agree - merging while we figure out how to handle argv.

MagnusS added a commit that referenced this pull request Jul 29, 2015
Add a function to extract the parameter list.
@MagnusS MagnusS merged commit 6c6ba9d into mirage:master Jul 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants