fix discover on Android #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, can you add something in Travis CI to ensure to keep the portability on Android? |
|
@dinosaure would you guys accept a github actions workflow instead? I have no experience with travis but I already have a github actions capable of testing this |
|
@EduardoRFS sure, we take any CI that works ;) |
EduardoRFS
force-pushed
the
master
branch
4 times, most recently
from
02d81cf
to
8f292a0
Compare
|
CI Added, here is the results on my repository
|
|
Thanks, did you want a release as soon as we can @EduardoRFS ? |
|
@dinosaure no pressure, I have this patch automatically applied for 3.0.1 |
4 tasks
dinosaure
added a commit
to dinosaure/opam-repository
that referenced
this pull request
Nov 19, 2020
…k-unix (3.1.0) CHANGES: * Use implicit executable dependency for discover.exe into the dune file (mirage/mirage-clock#46 @TheLortex) * Fix cross-compilation on Android (mirage/mirage-clock#45 @EduardoRFS)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android doesn't require
-lrtas it's built into the libc bionic.With Mirage can be compiled for Android using https://github.com/EduardoRFS/reason-mobile