Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add small example for postgres (using pgx) #288

Merged
merged 2 commits into from
May 12, 2020
Merged

add small example for postgres (using pgx) #288

merged 2 commits into from
May 12, 2020

Conversation

anuragsoni
Copy link
Contributor

This adds a very small example of a mirage unikernel interacting with a postgresql database using the newly published pgx_lwt_mirage library.

@MagnusS
Copy link
Member

MagnusS commented May 12, 2020

Restarted the CI build. It failed because of a temporary error with ocamlgraph which should be fixed now.

@anuragsoni
Copy link
Contributor Author

Restarted the CI build. It failed because of a temporary error with ocamlgraph which should be fixed now.

Thank you! The current test failures look unrelated, but if there is anything more that i should update for this PR do let me know 😄

@hannesm
Copy link
Member

hannesm commented May 12, 2020

would you mind to add device-usage/pgx to the list of BASE_TESTS in the Makefile at the root of this repository? this way, your pgx example will actually be compiled.

the CI errors (test runs on unix) are failing, which is unrelated to your PR, please ignore them.

@anuragsoni
Copy link
Contributor Author

would you mind to add device-usage/pgx to the list of BASE_TESTS in the Makefile at the root of this repository? this way, your pgx example will actually be compiled.

I figured i was missing something for tests. Updated the Makefile. Thanks!

@anuragsoni
Copy link
Contributor Author

I just realized that pgx is only available starting from ocaml 4.08. Is there a way to specify that it shouldn't be built on older ocaml versions that are tested in CI?

@hannesm
Copy link
Member

hannesm commented May 12, 2020

CI is testing this unikernel now, and discovering that it requires OCaml 4.08.0 (thus the 4.07 job fails). Merging. In a subsequent PR, I'll bump the OCaml versions used by CI.

@hannesm hannesm merged commit 137bd24 into mirage:master May 12, 2020
@anuragsoni
Copy link
Contributor Author

Thanks!

@anuragsoni anuragsoni deleted the add-pgx-example branch May 12, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants