New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to conduit 2.3 #1209
Adapt to conduit 2.3 #1209
Conversation
88249c0
to
b15a4c0
Compare
I'm ok to merge but small details remains. I would like to have the opinion/CI result from @TheLortex too. |
I'm very much in favor to get this merged and released, especially with the situation now: mirage 3.10 emits In the future, we should bump major revisions (i.e. conduit-mirage 2.3.0 should be 3.0.0 (or 4.0.0 in case the unavailable 3.0.0 is supposed to stay there) when the API changes. |
Me too 👍 I will try to update the PR from my comments. |
I have not reviewed this patch, nor followed conduit / cohttp API changes, nor tested this patch to work (but I trust you & Thomas). Looking at the mirage.mli changes in this PR this looks fine (and very backwards-compatible). A merge and release would be great. |
I tested locally and it's work, let's merge. |
…es (3.10.2) CHANGES: * Adapt to conduit 2.3 and cohttp 4.0 (@samoht @dinosaure mirage/mirage#1209) * Allow mirage-crypto-rng-mirage 0.9 (@hannesm mirage/mirage#1218) * Adapt to tcpip 6.1.0 release (the unix sublibrary is no longer needed)
Adapting to mirage/ocaml-conduit#376 and mirage/ocaml-cohttp#742