Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to conduit 2.3 #1209

Merged
merged 3 commits into from Mar 30, 2021
Merged

Adapt to conduit 2.3 #1209

merged 3 commits into from Mar 30, 2021

Conversation

samoht
Copy link
Member

@samoht samoht commented Feb 2, 2021

@samoht samoht force-pushed the conduit-2.3 branch 2 times, most recently from 88249c0 to b15a4c0 Compare February 5, 2021 14:43
lib/mirage_impl_http.ml Outdated Show resolved Hide resolved
@dinosaure
Copy link
Member

I'm ok to merge but small details remains. I would like to have the opinion/CI result from @TheLortex too.

@hannesm
Copy link
Member

hannesm commented Mar 29, 2021

I'm very much in favor to get this merged and released, especially with the situation now: mirage 3.10 emits conduit >= 2.2.0 & < 3.0.0 dependencies, which install conduit 2.3.0 (and cohttp 4.0.0), and compilation fails (try to compile e.g. https://github.com/roburio/dns-letsencrypt-secondary with an up-to-date opam-repository).

In the future, we should bump major revisions (i.e. conduit-mirage 2.3.0 should be 3.0.0 (or 4.0.0 in case the unavailable 3.0.0 is supposed to stay there) when the API changes.

@dinosaure
Copy link
Member

I'm very much in favor to get this merged and released, especially with the situation now: mirage 3.10 emits conduit >= 2.2.0 & < 3.0.0 dependencies, which install conduit 2.3.0 (and cohttp 4.0.0), and compilation fails (try to compile e.g. https://github.com/roburio/dns-letsencrypt-secondary with an up-to-date opam-repository).

Me too 👍 I will try to update the PR from my comments.

@dinosaure
Copy link
Member

I think it's ready to merge, it's ok to merge as is? (@hannesm, @samoht) and cut a release?

@hannesm
Copy link
Member

hannesm commented Mar 29, 2021

I have not reviewed this patch, nor followed conduit / cohttp API changes, nor tested this patch to work (but I trust you & Thomas). Looking at the mirage.mli changes in this PR this looks fine (and very backwards-compatible). A merge and release would be great.

@dinosaure
Copy link
Member

I tested locally and it's work, let's merge.

@dinosaure dinosaure merged commit ba11da9 into mirage:3 Mar 30, 2021
kit-ty-kate pushed a commit to ocaml/opam-repository that referenced this pull request Mar 30, 2021
…es (3.10.2)

CHANGES:

* Adapt to conduit 2.3 and cohttp 4.0 (@samoht @dinosaure mirage/mirage#1209)
* Allow mirage-crypto-rng-mirage 0.9 (@hannesm mirage/mirage#1218)
* Adapt to tcpip 6.1.0 release (the unix sublibrary is no longer needed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants