Adapt to conduit-mirage 2.3.0 #742
Conversation
|
I would like to prefer to keep |
|
This update becomes incompatible with It's hard to follow the implication of that when I suspect some incompatible types somewhere with MirageOS/Functoria but I can not make a minimal example of it. Note that |
|
The current state of mirage-conduit (where first-class modules are mixed with functors) is super confusing. The current design simplify a lot of things (and allows to add http_client combinators to the mirage DSL). I will have a look at |
samoht
force-pushed
the
conduit-2.3
branch
5 times, most recently
from
32b8b8e
to
64388f5
Compare
|
If we revert the last commit and run ocamlformat, this should also be good to go |
|
commit reverted + ocamlformat applied |
| R.resolve_uri ~uri resolver >>= fun endp -> | ||
| Endpoint.client ?tls_authenticator:authenticator endp >>= fun client -> | ||
| match conduit with | ||
| | None -> failwith "conduit not initialised" |
There was a problem hiding this comment.
Is it ok to use failwith instead of Lwt.raise or Lwt.failwith?
There was a problem hiding this comment.
Lwt.fail does not record the backtrace I believe
Adapt to mirage/ocaml-conduit#376