Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to new released mirage-xen & mirage-solo5 #1338

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Jul 24, 2022

require ocaml-solo5 0.8.1 and mirage-solo5 0.9.0 and mirage-xen 8.0.0

as discussed in mirage/mirage-xen#48

this PR may need to wait for ocaml/opam-repository#21860 and ocaml/opam-repository#21861

require ocaml-solo5 0.8.1 and mirage-solo5 0.9.0 and mirage-xen 8.0.0
@dinosaure
Copy link
Member

I relaunched the CI with a new fetch of opam-repository which should include new releases.

@hannesm
Copy link
Member Author

hannesm commented Jul 25, 2022

since the CI is still failing, I remember that it (used to?) has some specific opam-repository commit / is not updating the opam repository at each run -- is this correct (and could that please be documented somewhere @TheLortex)?

@TheLortex
Copy link
Member

It's failing because of the conflict between the unikernel's requirement on mirage-solo5 and mirage-bootvar-solo5's requirements:

- mirage-solo5 -> (problem)
    app-info-hvt zdev requires >= 0.9.0 & < 0.10.0
    mirage-bootvar-solo5 0.6.0 requires >= 0.6.0 & < 0.9.0
    Rejected candidates:
      mirage-solo5.0.9.0: Incompatible with restriction: >= 0.6.0 & < 0.9.0
      mirage-solo5.0.8.0: Incompatible with restriction: >= 0.9.0 & < 0.10.0
      mirage-solo5.0.7.0: Incompatible with restriction: >= 0.9.0 & < 0.10.0
      mirage-solo5.0.6.5: Incompatible with restriction: >= 0.9.0 & < 0.10.0
      mirage-solo5.0.6.4: Incompatible with restriction: >= 0.9.0 & < 0.10.0
      ...

@hannesm
Copy link
Member Author

hannesm commented Jul 25, 2022

ok, thanks. sorry for not reading the CI output correctly.

@TheLortex
Copy link
Member

ok, thanks. sorry for not reading the CI output correctly.

No problem, opam-monorepo's solving errors are still harder to read than opam ones as the solver implementation is different.

I have added a documentation section about updating the opam-repository commit: https://github.com/ocurrent/mirage-ci#updating-the-opam-repository-commit

@hannesm
Copy link
Member Author

hannesm commented Jul 25, 2022

I opened ocaml/opam-repository#21870 and mirage/mirage-bootvar-solo5#16 for resolving the CI issue

@hannesm
Copy link
Member Author

hannesm commented Jul 26, 2022

ok, CI is green now. anyone willing to review and merge?

@TheLortex TheLortex merged commit 1bfa661 into mirage:main Jul 26, 2022
@TheLortex
Copy link
Member

Sure, thanks

@hannesm hannesm deleted the new-mirage-solo5-mirage-xen branch July 26, 2022 13:53
hannesm added a commit to hannesm/opam-repository that referenced this pull request Jul 26, 2022
… (4.2.0)

CHANGES:

#### Fixed

- Remove non-existing mirage-repo-add and mirage-repo-rm from PHONY in generated
  Makefile (mirage/mirage#1332, @hannesm)
- Update deprecated references (mirage/mirage#1337, @reynir)

#### Changed

- Prepare for reproducing unikernels with generated opam file (mirage/mirage#1335, @hannesm)
  - split x-mirage-configure (mirage configure), x-mirage-pre-build
    (make lock pull), and build instructions in opam file
  - embed x-mirage-extra-repo (a list of opam repositories to use)
  - take relative paths up to git repository into account
  - include x-mirage-opam-lock-location (relative to git repository root)
- Adapt constraints for mirage-solo5 0.9.0 and mirage-xen 8.0.0 (ocaml-solo5
  0.8.1 with trim and improved memory metrics) (mirage/mirage#1338, @hannesm, based on
  @palainp work)
- Require opam-monorepo 0.3.2 (mirage/mirage#1332 mirage/mirage#1334, @hannesm @dinosaure)
- Use OPAMVAR_monorepo instead of OPAMVAR_switch in generated opam file (mirage/mirage#1332,
  @hannesm)
- Remove name from opam file (mirage/mirage#1332, @hannesm)
hannesm added a commit to hannesm/opam-repository that referenced this pull request Jul 27, 2022
… (4.2.0)

CHANGES:

#### Fixed

- Remove non-existing mirage-repo-add and mirage-repo-rm from PHONY in generated
  Makefile (mirage/mirage#1332, @hannesm)
- Update deprecated references (mirage/mirage#1337, @reynir)

#### Changed

- Prepare for reproducing unikernels with generated opam file (mirage/mirage#1335, @hannesm)
  - split x-mirage-configure (mirage configure), x-mirage-pre-build
    (make lock pull), and build instructions in opam file
  - embed x-mirage-extra-repo (a list of opam repositories to use)
  - take relative paths up to git repository into account
  - include x-mirage-opam-lock-location (relative to git repository root)
- Adapt constraints for mirage-solo5 0.9.0 and mirage-xen 8.0.0 (ocaml-solo5
  0.8.1 with trim and improved memory metrics) (mirage/mirage#1338, @hannesm, based on
  @palainp work)
- Require opam-monorepo 0.3.2 (mirage/mirage#1332 mirage/mirage#1334, @hannesm @dinosaure)
- Use OPAMVAR_monorepo instead of OPAMVAR_switch in generated opam file (mirage/mirage#1332,
  @hannesm)
- Remove name from opam file (mirage/mirage#1332, @hannesm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants