Add tar_kv_ro and tar_kv_rw #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks nice in general, but the Tar_mirage.Make_KV_RW functor expects a PCLOCK and a BLOCK device, so we cannot uniformly handle it. Also, the |
hannesm
reviewed
Feb 3, 2023
`Tar_mirage.Make_KV_RW` first appeared in 2.2.0.
|
looks good, please bow to |
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Feb 23, 2023
… (4.3.4) CHANGES: #### Fixed - Add -f <config> to Makefile output (mirage/mirage#1394 @hannesm) #### Added - Add tar_kv_ro and tar_kv_rw (mirage/mirage#1389 @reynir) #### Changed - Improved documentation of mirage.mli (mirage/mirage#1390 mirage/mirage#1391 @reynir) - Deprecate Mirage.archive (use tar_kv_ro, mirage/mirage#1389 @reynir) - Removed deprecated device git_happy_eyeballs (mirage/mirage#1388 @TaeminHa) - Adapt bounds: mirage-crypto 0.11.0 (mirage/mirage#1392 @hannesm) git-mirage 2.13.0 (mirage/mirage#1396 @hannesm) dns 7.0.0 tls 0.16.0 (mirage/mirage#1399 @hannesm) mirage-block-ccm (mirage/mirage#1400 @hannesm) - mirage-runtime: conflict with ppxlib 0.29 (mirage/mirage#1397 @hannesm) - add upper bound to dune 3.7 until a release of chamelon with fixes lands (see mirage/mirage#1401 (comment))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition,
archiveis deprecated in favor oftar_kv_roandtar_kv_rw.