Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for 4.3.4 #1401

Merged
merged 5 commits into from
Feb 23, 2023
Merged

changes for 4.3.4 #1401

merged 5 commits into from
Feb 23, 2023

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Feb 17, 2023

No description provided.

@TheLortex
Copy link
Member

CI success depends on conduit.6.2.0 being released ocaml/opam-repository#23344 (see #1399 (comment))

@hannesm
Copy link
Member Author

hannesm commented Feb 22, 2023

ok, so the final commit is a bit questionable, as @TheLortex mentioned in #1399 (comment) the underlying issue is that dune 3.7 broke compilation of chamelon, and the workflow of mirage doesn't take the chamelon upper bounds into consideration -- and the dune used is indeed 3.7 which breaks the build

now, my question is: should we merge and release? or should we remove the last commit (and thus no dune upper bound)? the latter would lead to potential users of chamelon in a mirage unikernel finding strange error messages... what do you think?

@palainp
Copy link
Member

palainp commented Feb 23, 2023

In my opinion, we should keep the last commit to ensure that users can compile without issues, merge and release plus remove it when chamelon#18 is merged (and release another minor version).

@hannesm hannesm merged commit ae31371 into mirage:main Feb 23, 2023
@hannesm hannesm deleted the changes branch February 23, 2023 10:16
hannesm added a commit to hannesm/opam-repository that referenced this pull request Feb 23, 2023
… (4.3.4)

CHANGES:

#### Fixed

- Add -f <config> to Makefile output (mirage/mirage#1394 @hannesm)

#### Added

- Add tar_kv_ro and tar_kv_rw (mirage/mirage#1389 @reynir)

#### Changed

- Improved documentation of mirage.mli (mirage/mirage#1390 mirage/mirage#1391 @reynir)
- Deprecate Mirage.archive (use tar_kv_ro, mirage/mirage#1389 @reynir)
- Removed deprecated device git_happy_eyeballs (mirage/mirage#1388 @TaeminHa)
- Adapt bounds: mirage-crypto 0.11.0 (mirage/mirage#1392 @hannesm) git-mirage 2.13.0
  (mirage/mirage#1396 @hannesm) dns 7.0.0 tls 0.16.0 (mirage/mirage#1399 @hannesm)
  mirage-block-ccm (mirage/mirage#1400 @hannesm)
- mirage-runtime: conflict with ppxlib 0.29 (mirage/mirage#1397 @hannesm)
- add upper bound to dune 3.7 until a release of chamelon with fixes lands (see
  mirage/mirage#1401 (comment))
hannesm added a commit to hannesm/opam-repository that referenced this pull request Feb 24, 2023
We thought (for Mirage CI and chamelon-based unikernels) this to be a great
idea, but unfortunately our mirage-www website unikernel fails (due to
opam-monorepo deciding to use dune 3.7.0 and then selecting mirage 4.3.3).

The whole story is mirage/mirage-www#795 (comment)
combined with mirage/mirage#1401 (comment)

For the medium term, we already have another solution in mind.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants