mirage: adjust name (argv_qubes is gone, this is argv_xen) #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably worth a rebase against master to see if the CI goes green. |
|
Actually I can probably force push a rebase myself easily enough... |
|
OK, I've force pushed a rebase. Let's see if the CI is working (in general) |
samoht
reviewed
Jul 20, 2017
| @@ -1246,7 +1246,7 @@ let no_argv = impl @@ object | |||
| let argv_xen = impl @@ object | |||
| inherit base_configurable | |||
| method ty = Functoria_app.argv | |||
| method name = "argv_qubes" | |||
| method name = "argv_xen" | |||
There was a problem hiding this comment.
does it need a change in the package constraints too?
There was a problem hiding this comment.
it's only the name, not used for any package dependencies..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.