Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mirage: adjust name (argv_qubes is gone, this is argv_xen) #838

Merged
merged 1 commit into from
Jul 20, 2017
Merged

mirage: adjust name (argv_qubes is gone, this is argv_xen) #838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/mirage.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1246,7 +1246,7 @@ let no_argv = impl @@ object
let argv_xen = impl @@ object
inherit base_configurable
method ty = Functoria_app.argv
method name = "argv_qubes"
method name = "argv_xen"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it need a change in the package constraints too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's only the name, not used for any package dependencies..

method module_name = "Bootvar"
method packages = Key.pure [ package ~min:"0.4.0" "mirage-bootvar-xen" ]
method connect _ _ _ = Fmt.strf
Expand Down