Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CRC32 initialisation and finalisation #168

Merged
merged 1 commit into from
Oct 17, 2016
Merged

Conversation

g2p
Copy link
Contributor

@g2p g2p commented Oct 17, 2016

See #166.

@g2p
Copy link
Contributor Author

g2p commented Oct 17, 2016

There are still 6 failing tests if I run make && _build/lib_test/test.native test, but none that weren't failing before (mostly due to ECONNREFUSED).

@samoht
Copy link
Member

samoht commented Oct 17, 2016

Thanks!

Travis is running the "fast" tests only, I should probably change that. The other tests needs ./scripts/git-dumb-server to run in an other terminal.

@samoht samoht merged commit bd9c8f3 into mirage:master Oct 17, 2016
@samoht
Copy link
Member

samoht commented Oct 17, 2016

Hum, I still have an issue with FS 11:

$ cd lib_test && ../_build/lib_test/test.native test FS 11
[..]
error: HEAD: not a commit
broken link from  commit 17498114d5eb1beb64418071025f0555887668ec
              to  commit cca30fe9644f6181a0aec72148f768f21a75eaa1
broken link from  commit 17498114d5eb1beb64418071025f0555887668ec
              to  commit 7c6760799c7845f565c9f29cccc02971e417f8c5
missing commit 7c6760799c7845f565c9f29cccc02971e417f8c5
missing commit cca30fe9644f6181a0aec72148f768f21a75eaa1
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
ASSERT fsck
-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
[failure] Error fsck: expecting 0, got 10.

@samoht
Copy link
Member

samoht commented Oct 17, 2016

I seems to see it with previous versions of ocaml-git too, so that's not related to your patch. Seems that the new commits exposed a real bug somewhere else... (the "slow" unit tests clone this repository with various options) ... Interesting!

@samoht
Copy link
Member

samoht commented Oct 17, 2016

So it seems that this is due to the fact that ocaml-git doens't create shallow Git repository correctly (this is related to #45), ie. we understand, read and unpack shallow pack files, but we don't create the right shallow metadata in .git/* so git fsck becomes very confused.

So not a regression, and the new crc code seems to work quite right! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants