Updates from xen-api-libs/rpc-light #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 23, 2012 15:24
This avoids having to pass in an "rpc" argument on every call; instead one can write let module M = Client(struct let rpc = ... end) in M.just_do_it () Patch originally written by: Rob Hoes <rob.hoes@citrix.com> Patch ported from xen-org/xen-api-libs c/s 66476cba733fde295aa433092632556111cfa4a5
Define your exceptions at the top level in your idl file, then raise them in the server and they'll be reraised in the client. Signed-off-by: Jon Ludlam <jonathan.ludlam@eu.citrix.com>
Signed-off-by: Jon Ludlam <jonathan.ludlam@eu.citrix.com>
Add the line: let version="<version>" to your interface definition file, and this will autogenerate a 'get_version' RPC call to the client and server. This will _not_ be present in the server functor signature. The idea is that the client calls this immediately and asserts that the result is identical to its own binding of 'version'. If this fails, the client can then try to find the correct server version on a different URI. Signed-off-by: Jon Ludlam <jonathan.ludlam@eu.citrix.com>
The normal workaround for this is to marshal as a string instead. Note the unmarshalling functions already handle this case. Signed-off-by: David Scott <dave.scott@eu.citrix.com>
This allows clients to avoid buffering large intermediate strings.
samoht
added a commit
that referenced
this pull request
Oct 28, 2012
Updates from xen-api-libs/rpc-light
|
thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of stuff including