gen_service: change code generation strategy to avoid big switches #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See mirage#106: the gigantic pattern-matching in the code generated by gen_service.ml hit code generation bug on ARM backends. The new code only generate large arrays (these could easily be split if further issues were reported), and uses dichotomic search on sorted array to map services to ports and conversely. On my (x86_64) machine, build time changes from 45s to 4.5s.
|
Thanks! Restarted failed build |
|
The error is the same as for #113, there seems to be an error in the ubuntu package database (the package that the CI machines try to access indeed doesn't seem to exist anymore), this is not just a transient package-download error -- but it could be caused by a transient error in accessing updated package metadata. |
|
@avsm gentle ping: I think the CI failure may be safely ignored here. |
avsm
added a commit
to mirage/opam-repository
that referenced
this pull request
Jan 12, 2018
* Change code generation strategy to avoid big switches in the services file; improves build time by 10x (mirage/ocaml-uri#114 by @gasche). * Remove deprecated function use (`String.lowercase`) * Add development Makefile with more targets.
copy
pushed a commit
to copy/opam-repository
that referenced
this pull request
Jan 17, 2018
* Change code generation strategy to avoid big switches in the services file; improves build time by 10x (mirage/ocaml-uri#114 by @gasche). * Remove deprecated function use (`String.lowercase`) * Add development Makefile with more targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #106: the gigantic
pattern-matching in the code generated by gen_service.ml hit code
generation bug on ARM backends.
The new code only generate large arrays (these could easily be split
if further issues were reported), and uses dichotomic search on sorted
array to map services to ports and conversely.
On my (x86_64) machine, build time changes from 45s to 4.5s.