Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code build with docker #102

Closed
wants to merge 3 commits into from
Closed

Add code build with docker #102

wants to merge 3 commits into from

Conversation

linse
Copy link
Collaborator

@linse linse commented May 19, 2020

Hi @talex5 , we needed to add these lines in order to run build_with_docker.sh successfully on a Debian qube with Docker version 19.03.9. Do you think this change is sensible or is it intended to be called in a different way? We took these lines from .travis.yml

@talex5
Copy link
Collaborator

talex5 commented May 19, 2020

What was the error when you tried? You shouldn't need to copy the source into the image, as the build-with-docker.sh script shares the host directory.

@hannesm
Copy link
Member

hannesm commented May 19, 2020

the error we see without the two lines is:

Step 8/8 : CMD opam config exec -- mirage configure -t xen &&     opam config exec -- make tar
 ---> Running in 8b8bfccad6a4
Removing intermediate container 8b8bfccad6a4                                                                       
 ---> 81a3a8ecc5ce
Successfully built 81a3a8ecc5ce
Successfully tagged qubes-mirage-firewall:latest
Building Firewall...                             
mirage build
sh: /home/opam/qubes-mirage-firewall/_build/myocamlbuild: not found
run ['ocamlbuild' '-use-ocamlfind' '-classic-display' '-quiet' '-tags'
'predicate(mirage_xen),warn(A-4-41-42-44-48),debug,bin_annot,strict_sequence,principal,safe_string'
     '-pkgs'
arp,arp-mirage,astring,cstruct,dns-client,ethernet,functoria-runtime,ipaddr,lwt,mirage-clock-freestanding,mirage-crypto-entropy,mirage-logs,mirage-nat,mirage-net-xen,mirage-protocols,mirage-qubes,mirageruntime,miragetypes,mirage-types-lwt,mirage-xen,netchannel,pf-qubes,shared-memory-ring,tcpip,vchan'
     '-cflags' '-g' '-lflags'                                                                   
     '-g,-dontlink,unix,-dontlink,str,-dontlink,num,-dontlink,threads'                          
     '-tag-line' '<static*.*>: warn(-32-34)' '-Xs'                                             
     '_build-solo5-hvt,_build-ukvm' 'main.native.o']: exited with 127
run ['dune' 'exec' '--root' '/home/opam/qubes-mirage-firewall' '--'                              
     './config.exe' 'build']: exited with 1                                                      
make: *** [Makefile:18: build] Error 1                                                            

@talex5
Copy link
Collaborator

talex5 commented May 19, 2020

Maybe you have a stale _build directory (try deleting it). But I don't understand why this change would make any difference, since the script mounts the source directory over whatever is in the image at /home/opam/qubes-mirage-firewall anyway.

@hannesm
Copy link
Member

hannesm commented May 19, 2020

we tried again, and cannot reproduce. thanks for your input.

@hannesm hannesm closed this May 19, 2020
@hannesm hannesm deleted the add-code-build-with-docker branch May 19, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants