Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding more descriptive namespace error #1041

Merged
merged 3 commits into from
May 19, 2022
Merged

Adding more descriptive namespace error #1041

merged 3 commits into from
May 19, 2022

Conversation

srikanthkyatham
Copy link
Contributor

No description provided.

@IanVS
Copy link
Collaborator

IanVS commented May 19, 2022

Fixing other lint error.

😂

Sorry for the hassle.

@srikanthkyatham
Copy link
Contributor Author

I am using prettier doing all the job :).

IanVS
IanVS approved these changes May 19, 2022
View reviewed changes
Copy link
Collaborator

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@IanVS IanVS merged commit c15a147 into miragejs:master May 19, 2022
@cah-brian-gantzler
Copy link
Collaborator

This code has been extracted to https://github.com/bgantzler/mirage-pretender/blob/master/lib/pretender-config.js#L309 and will be removed in my next PR. If there are any future updates to this file please make sure I know or do an equivalent PR for the mirage-pretender repo

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanVS IanVS IanVS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srikanthkyatham @IanVS @cah-brian-gantzler