Fix stale request object when an explicit serializer type is passed

__tests__/internal/move-after-handle-request/regressions/885-serializer-stale-request-bug-test.js

@@ -0,0 +1,43 @@
+import { Server, Model, JSONAPISerializer, Response } from "miragejs";
+
+describe("Integration | Server | Regressions | 885 Serializer stale request bug test", function () {
+  let server;
+
+  beforeEach(function () {
+    server = new Server({
+      environment: "test",
+      models: {
+        eel: Model.extend(),
+      },
+      serializers: {
+        clawlessEel: JSONAPISerializer,
+      },
+      routes() {
+        this.get("/tigers/:id", new Response());
+        this.get("/eels/:id", function (schema, request) {
+          let eel = schema.eels.find(request.params.id);
+          return this.serialize(eel, "clawlessEel");
+        });
+      },
+    });
+  });
+
+  afterEach(function () {
+    server.shutdown();
+  });
+
+  test("it works", async () => {
+    let eel = server.create("eel");
+
+    expect.assertions(1);
+
+    // Make sure there is a request with an `include` query param that refers to a relationship that
+    // doesn't exist on the `eel` resource, so that `JSONAPISerializer` would throw if the request
+    // inside Mirage ends up staying the same when fetching `/eels/:id`.
+    await fetch(`/tigers/1?include=claws`);
+
+    let res = await fetch(`/eels/${eel.id}`);
+
+    expect(res.status).toEqual(200);
+  });
+});

lib/serializer.js

@@ -406,9 +406,17 @@ class Serializer {
     @param request
     @return { Object } the json response
    */
-  serialize(primaryResource /* , request */) {
+  serialize(primaryResource, request) {
     this.primaryResource = primaryResource;
 
+    // The if statement only guards agains not passing the request object when overriding the
+    // method, to avoid breaking changes.
+    //
+    // See: https://github.com/miragejs/miragejs/pull/1103
+    if (request) {
+      this.request = request;
+    }
+
     return this.buildPayload(primaryResource);
   }