Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review GitHub Actions for Shiny CI/CD #30

Merged
merged 8 commits into from
Nov 24, 2021
Merged

Review GitHub Actions for Shiny CI/CD #30

merged 8 commits into from
Nov 24, 2021

Commits on Oct 29, 2021

  1. Fix CI/CD steps in the context of GH Actions #29

    @riccardoporreca
    riccardoporreca committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    b846e85 View commit details
    Browse the repository at this point in the history

  2. Align and fix redirected GitHub docs URLs #29 

    * Redirections detected with HTMLProofer, new URLs via `curl -iv`

```sh
docker run --rm -it -v $(pwd):/src --entrypoint ruby klakegg/html-proofer -e "require 'html-proofer'" -e "
HTMLProofer.check_directory('_book/', {
  :check_external_hash => true,
  :typhoeus => {:followlocation => false}
}).run
"
```
    @riccardoporreca
    riccardoporreca committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    e688ad4 View commit details
    Browse the repository at this point in the history

  3. Maintenance: Align remaining redirected URLs across the board 

    * Redirections detected with HTMLProofer, new URLs via `curl -iv`

```sh
docker run --rm -it -v $(pwd):/src --entrypoint ruby klakegg/html-proofer -e "require 'html-proofer'" -e "
HTMLProofer.check_directory('_book/', {
  :check_external_hash => true,
  :typhoeus => {:followlocation => false}
}).run
"
```
    @riccardoporreca
    riccardoporreca committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    c090469 View commit details
    Browse the repository at this point in the history

  4. Pull in simplified workflows as updated in miraisolutions/ShinyCICD#6 (… 

    …#29)

Specifically, via:
```r
usethis::use_github_file(
  "miraisolutions/ShinyCICD", ref = "7a879c578be4b8faab7972a5a774da617deb08b9",
  ".github/workflows/ci-cd.yml", "shiny-ci-cd/actions/ci-cd.yml"
)
usethis::use_github_file(
  "miraisolutions/ShinyCICD", ref = "7a879c578be4b8faab7972a5a774da617deb08b9",
  ".github/workflows/ci-cd-renv.yml", "shiny-ci-cd/actions/ci-cd-renv.yml"
)
```
    @riccardoporreca
    riccardoporreca committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    24798ad View commit details
    Browse the repository at this point in the history

  5. Review Shiny CI/CD with Actions in light of simplified workflows #29 

    * Includes new picture
    @riccardoporreca
    riccardoporreca committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    4b3100a View commit details
    Browse the repository at this point in the history

  6. Fix use_github_action(), now only allowing GitHub URLs (#29) 

    * See r-lib/usethis#1407, introduced in usethis v2.1.0
    @riccardoporreca
    riccardoporreca committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    d36ea79 View commit details
    Browse the repository at this point in the history

  7. Simplify techguides own CI/CD workflow (#29) 

    * Based on the `r-lib/actions/setup-r-dependencies`.
* Also include TODO about switching to `JamesIves/github-pages-deploy-action` for deployment, which is what used in `r-lib/actions/examples`.
    @riccardoporreca
    riccardoporreca committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    16dfe2d View commit details
    Browse the repository at this point in the history

  8. Simplify techguides own CI/CD workflow #31 

    Merge pull request from miraisolutions/feature/29-simplify-techguides-ci-cd-workflow
    @riccardoporreca
    riccardoporreca committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    33bd9f5 View commit details
    Browse the repository at this point in the history