Add Credo 1.4-specific features #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi
force-pushed
the
feature/add-credo-1.4-features
branch
from
7b1ca72
to
e62b7da
Compare
gcauchon
approved these changes
May 7, 2020
simonprev
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well most of these features are actually from Credo 1.3.
We’re now using the
explanations(1.3),params_defaults(1.3) andtags(1.4) options in theuse Credo.CheckAPI.The only thing that needed refactoring is that since we have to declare default values for params at compile time instead of runtime, the
valid_filename_callbackneeds to support the{mod, fun}syntax in addition to the&fun/3syntax (for backward compatibility).Closes #10