Various performance improvements #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"(implementation" -> "(implementation)"
…loops About 30% performance improvement (from 170ms to 120ms). * Use native Array.isArray instead of comparing [[Class]] via toString. Seems to reliably save about 10ms in performance, and makes more sense in general. * Cache hasOwnProperty. Instead of requesting a global variable and two property levels inside the loop, cache it once. * Don't use a for-in loop over an array. For-in loops are for objects, not arrays. They scan through the entire inheritance chain (thus needing a hasOwn check) and they potentially yield keys in the wrong order (ironic, since this code is all about avoiding internal sort and using alphabetical instead). Performance (average of 10 runs): - Before (2167f41) - native: 46-48ms - js stringify with js sort: 165-173ms - native stringify with js sort: 170-176ms - After - native: 47-53ms - js stringify with js sort: 165-171ms - native stringify with js sort: 124-129ms
mirkokiefer
added a commit
that referenced
this pull request
Jun 27, 2014
Various performance improvements
|
Nice, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About 30% performance improvement (from 170ms to 120ms).