Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headers names and values autocomplete using datalist #191

Merged
merged 1 commit into from Jun 23, 2023

Conversation

nikhilraojl
Copy link
Contributor

@nikhilraojl nikhilraojl commented Jun 16, 2023

image

image

Pics for reference

@nikhilraojl nikhilraojl marked this pull request as draft June 16, 2023 14:30
Copy link
Owner

@mirkoperillo mirkoperillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikhilraojl very good work. I like it and it works good.

I have to report only these two things:

  • The code format should be fixed, because the CI format check fails
  • When you click enter on the header value input field the focus moves back to the header key input field and this is a regression (if you look for example the Querystring tab you can see the correct behavior)

@nikhilraojl
Copy link
Contributor Author

@mirkoperillo Sorry for delay, was slightly occupied

The code format should be fixed, because the CI format check fails

The issue is prettier does not automatically apply quotes for all keys in an object and it is default as shown below

{ 
  Accept: [],  // observe no quotes
  'Accept-Charset': []
  ...
}

On my local I have added "quoteProps": "consistent" to .prettierrc file and it results in formatting as below

{ 
  'Accept': [],  // observe consistent quotes
  'Accept-Charset': []
  ...
}

I think we should add that rule to prettier. Its your call but for now I have formatted this PR with default rule and CI is passing

When you click enter on the header value input field the focus moves back to the header key input field and this is a regression (if you look for example the Querystring tab you can see the correct behavior)

This should be resolved now

@nikhilraojl nikhilraojl marked this pull request as ready for review June 23, 2023 07:30
@mirkoperillo
Copy link
Owner

@nikhilraojl LGTM, very good work.
Time to merge it ! 💥

@mirkoperillo mirkoperillo changed the title WIP: Add headers names and values autocomplete using datalist Add headers names and values autocomplete using datalist Jun 23, 2023
@mirkoperillo mirkoperillo merged commit 52d009e into mirkoperillo:master Jun 23, 2023
1 check passed
@nikhilraojl nikhilraojl deleted the headers_completion branch July 7, 2023 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants