Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigarray and cstruct >= 5.0.0 #28

Closed
NathanReb opened this issue Jun 11, 2019 · 2 comments
Closed

Bigarray and cstruct >= 5.0.0 #28

NathanReb opened this issue Jun 11, 2019 · 2 comments

Comments

@NathanReb
Copy link

cstruct 5.0.0 appears to have dropped its dependency over bigarray which causes linking issues with asn1-combinators as it was transitively depending on it.

#27 fixes it for future versions but it might be worth updating a few opam files on opam-repository by adding an upper bound to the cstruct dependency.

I'm happy to help with that if you don't have time to take care of it so let me know what you think!
avsm added a commit to avsm/opam-repository that referenced this issue Jun 11, 2019
@avsm
asn1-combinators: constrain to cstruct<5
dd1f1e1 
see mirleft/ocaml-asn1-combinators#28
@avsm avsm mentioned this issue Jun 11, 2019
Merged
@XVilka
Copy link

XVilka commented Jun 17, 2019

Are there any updates on this?

@TheLortex TheLortex mentioned this issue Jun 17, 2019
Merged
@hannesm
Copy link
Member

hannesm commented Jan 28, 2020

thanks for the report.

ocaml/opam-repository#15199 added a patch for asn1-combinators 0.2.0; #27 is now merged as #31.

@hannesm hannesm closed this as completed Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@XVilka @hannesm @NathanReb