tls-eio: Fix end-of-file handling #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I introduced this bug in f328099 (not in the history due to squash merge). However, setting the state to `Eof` is not the same as reporting end-of-file to the user, and we may still have data to report. This can cause us to miss data at the end of the stream in some cases.
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Oct 25, 2022
CHANGES: * tls-eio release only: fix end-of-file handling (mirleft/ocaml-tls#454 @talex5), avoid deprecation warnings (mirleft/ocaml-tls#454 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced this bug in f328099 (not in the history due to squash merge). However, setting the state to
Eofis not the same as reporting end-of-file to the user, and we may still have data to report. This can cause us to miss data at the end of the stream in some cases.