remove ppx (cstruct and sexplib), removing sexplib converters #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
force-pushed
the
no-ppx-cstruct
branch
from
62c983a
to
9ec45e5
Compare
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Mar 1, 2023
CHANGES: * tls-async: remove ocaml < 5.0.0 constraint (mirleft/ocaml-tls#471 mirleft/ocaml-tls#474 @hannesm) * remove dependency on ppx, especially ppx_cstruct and ppx_sexp_conv across the libraries (mirleft/ocaml-tls#473 @hannesm, discussion in mirleft/ocaml-tls#472)
|
failing reverse dependencies:
|
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Mar 1, 2023
CHANGES: * tls-async: remove ocaml < 5.0.0 constraint (mirleft/ocaml-tls#471 mirleft/ocaml-tls#474 @hannesm) * remove dependency on ppx, especially ppx_cstruct and ppx_sexp_conv across the libraries (mirleft/ocaml-tls#473 @hannesm, discussion in mirleft/ocaml-tls#472)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see discussion in #472 -- main purpose is to shave the dependency cone (and binary size reduces from 1.3 to 1.0 MB of tls.a)
still open for discussion (feedback, suggestions). will look into CI failures...