Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API woes #106

Closed
hannesm opened this issue Apr 19, 2018 · 1 comment
Closed

API woes #106

hannesm opened this issue Apr 19, 2018 · 1 comment

Comments

@hannesm
Copy link
Member

hannesm commented Apr 19, 2018

a list of improvements of the API:

  • X509.Encoding.PEM.*.of_string should not throw Invalid_arg (at least those used for public keys)
  • use the result type instead (and also elsewhere)
  • provide pp (i.e. Formatter) instead of to_string
  • use Logs all over
  • get rid of X509.Validation.result type
  • on another note, the testsuite could be ported to alcotest instead of oUnit
@hannesm
Copy link
Member Author

hannesm commented Apr 29, 2019

fixed in #113

@hannesm hannesm closed this as completed Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hannesm