Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing error in extract_data_from_request #1185

Closed
elbaro opened this issue Jun 6, 2024 · 0 comments · Fixed by #1186
Closed

Typing error in extract_data_from_request #1185

elbaro opened this issue Jun 6, 2024 · 0 comments · Fixed by #1186
Assignees
Labels
bug Something isn't working

Comments

@elbaro
Copy link

elbaro commented Jun 6, 2024

    async def extract_data_from_request(self, request: Request):
        """Extracts GraphQL request data from request.

        Returns a `dict` with GraphQL query data that was not yet validated.
        ...
        """
        ...
        if content_type == DATA_TYPE_JSON:
            return await self.extract_data_from_json_request(request)
        if content_type == DATA_TYPE_MULTIPART:
            return await self.extract_data_from_multipart_request(request)

extract_data_from_multipart_request returns dict | list but extract_data_from_request docstring says it's always dict.
pyright think extract_data_from_request returns dict | list.

@DamianCzajkowski DamianCzajkowski added the bug Something isn't working label Jun 13, 2024
@DamianCzajkowski DamianCzajkowski self-assigned this Jun 13, 2024
@DamianCzajkowski DamianCzajkowski linked a pull request Jun 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants