Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove contrib django #696

Merged
merged 2 commits into from Oct 15, 2021
Merged

Remove contrib django #696

merged 2 commits into from Oct 15, 2021

Conversation

rafalp
Copy link
Contributor

@rafalp rafalp commented Oct 15, 2021

This was long time coming, but now that you can install better django support lib via ariadne_django, we can finally drop it from our core package.

@rafalp rafalp self-assigned this Oct 15, 2021
@rafalp rafalp added this to the Ariadne 0.14 milestone Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #696 (41f8445) into master (260d7c0) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #696      +/-   ##
==========================================
- Coverage   98.22%   98.09%   -0.13%     
==========================================
  Files         104       93      -11     
  Lines        5399     5033     -366     
==========================================
- Hits         5303     4937     -366     
  Misses         96       96              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 260d7c0...41f8445. Read the comment docs.

@rafalp rafalp requested a review from bogdal October 15, 2021 10:15
Copy link
Member

@bogdal bogdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥 🔥

@rafalp rafalp merged commit 1081278 into master Oct 15, 2021
@rafalp rafalp deleted the remove-contrib-django branch October 15, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants