Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some utilities to public API #803

Merged
merged 65 commits into from
Mar 25, 2022
Merged

Move some utilities to public API #803

merged 65 commits into from
Mar 25, 2022

Conversation

rafalp
Copy link
Contributor

@rafalp rafalp commented Feb 25, 2022

This PR moves following utils into public API, as they are also used in ariadne-graphql-modules:

  • set_default_enum_values_on_schema
  • type_implements_interface
  • validate_schema_enum_values

@rafalp rafalp added this to the Ariadne 0.15 milestone Feb 25, 2022
@rafalp rafalp self-assigned this Feb 25, 2022
@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #803 (a563e65) into master (289df96) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #803   +/-   ##
=======================================
  Coverage   98.06%   98.06%           
=======================================
  Files          93       93           
  Lines        5263     5267    +4     
=======================================
+ Hits         5161     5165    +4     
  Misses        102      102           
Impacted Files Coverage Δ
ariadne/__init__.py 100.00% <100.00%> (ø)
ariadne/contrib/federation/interfaces.py 100.00% <100.00%> (ø)
ariadne/interfaces.py 100.00% <100.00%> (ø)
ariadne/utils.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@rafalp rafalp changed the title Add new OO API Move some utilities to public API Mar 23, 2022
@rafalp rafalp marked this pull request as ready for review March 25, 2022 10:52
@rafalp rafalp merged commit fe9c278 into master Mar 25, 2022
@rafalp rafalp deleted the new-object-api branch March 25, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant