-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add minimal quantity of products for voucher #4427
Add minimal quantity of products for voucher #4427
Conversation
0e7184a
to
8cc8277
Compare
Here is the report for f6a298b (mirumee/saleor @ 4316/voucher_min_qunantity_of_products) No differences were found. (click me)
# api.benchmark checkout
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
add billing address to checkout 34 34 20
add shipping to checkout 7 7 0
checkout payment charge 14 14 0
complete checkout 6 6 0
create checkout 43 43 21
# api.benchmark homepage
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve main menu 5 5 0
retrieve product list 4 4 0
retrieve secondary menu 5 5 0
retrieve shop 2 2 0
# api.benchmark product
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
product details 13 13 3
# api.benchmark variant
test name left count right count duplicate count
------------------------------------ ----------- ----------- ---------------
retrieve variant list 9 9 2 |
Codecov Report
@@ Coverage Diff @@
## master #4427 +/- ##
==========================================
+ Coverage 90.7% 90.75% +0.04%
==========================================
Files 291 291
Lines 16680 16694 +14
Branches 1691 1692 +1
==========================================
+ Hits 15130 15150 +20
+ Misses 1054 1049 -5
+ Partials 496 495 -1
Continue to review full report at Codecov.
|
17386f0
to
6f52952
Compare
I want to merge this change because resolve #4316 and fix #4379
Screenshots
Pull Request Checklist