Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ebl refactor #15

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Ebl refactor #15

merged 2 commits into from
Nov 16, 2022

Conversation

misaim
Copy link
Owner

@misaim misaim commented Nov 16, 2022

Liam Frappell added 2 commits November 16, 2022 14:30
… moved required globals to ebl.py and set up handling in __name__.
…rhauled README. Added license stuff cause why not. Refactored no-write option to work with single files. Upgraded time logging.
Copy link
Collaborator

@jackbucinskas jackbucinskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for these changes, please review my comments

regards, j

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
src/ebl.py Show resolved Hide resolved
src/ebl.py Show resolved Hide resolved
file_writer.write(wav_data)
return

def dummy_file():
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to '/test/test_main.py'

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah probs

src/main.py Show resolved Hide resolved
src/main.py Show resolved Hide resolved
src/ebl.py Show resolved Hide resolved
@misaim misaim merged commit fc4ffad into main Nov 16, 2022
@misaim misaim deleted the ebl-refactor branch November 16, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Input File Exists
2 participants