Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

directional (arrow) keys being interpreted improperly #7

Closed
michaelficarra opened this issue Aug 1, 2011 · 7 comments
Closed

directional (arrow) keys being interpreted improperly #7

michaelficarra opened this issue Aug 1, 2011 · 7 comments

Comments

@michaelficarra
Copy link

It seems <up> is now a synonym for u, <down> is now a synonym for d, and so on.

@michaelficarra
Copy link
Author

@misfo
Copy link
Owner

misfo commented Aug 1, 2011

Yikes! The ace keybinding interface just changed and it sounds like we have some regressions. Time to improve the test coverage. Thanks for the report

On Aug 1, 2011, at 6:35 PM, michaelficarrareply@reply.github.com wrote:

It seems <up> is now a synonym for u, <down> is now a synonym for d, and so on.

Reply to this email directly or view it on GitHub:
#7

@misfo misfo closed this as completed in e83f766 Aug 2, 2011
@misfo
Copy link
Owner

misfo commented Aug 2, 2011

pushed this to gh-pages too. we've got some tests to prevent a regression like this again

@michaelficarra
Copy link
Author

Huh. Now the arrow keys in visual mode are displaying the same visual mode quirks as before your ace update, but h, j, k, l in visual (and visual line) mode work properly.

@misfo
Copy link
Owner

misfo commented Aug 2, 2011

I hate to give a works-for-me-there's-no-way-my-code's-wrong response, but are you sure you're not getting a cached version? Can you see the fixed line in lib/ace/module.js in your browser's web inspector?

Chrome's force-refresh makes me think I'm taking crazy pills. It will still render files from the local cache. Clearing the cache is the only way I've been able to force bypassing it's cache...

@michaelficarra
Copy link
Author

Yeah, I made sure to clear the cache and compared the JS against the new version because that was my first suspicion as well.

@misfo
Copy link
Owner

misfo commented Aug 2, 2011

I misread your comment. I'm getting the same behavior you described.

Ace's default keybindings for arrow keys clear the selection whenever you press them without the shift key. Jim has always passed arrow keypresses through to Ace, so this behavior must have been the same before this commit.

The arrow keys should be mapped to their hjkl counterparts. I'll create an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants