Mangling parameter names in strict mode results in Safari Syntax Error

[ligaz]

The following code:

'use strict'
var a = function n(param1) {
}

When minified with: --compress --mangle --keep-fnames
Results in:

"use strict";var a=function n(n){};

Unfortunately this breaks Safari with: SyntaxError: Cannot declare a parameter named 'n' as it shadows the name of a strict mode function.

[kzc]

The original unmodified input would have the same issue.

[ligaz]

My bad, I have corrected the original code.

[kzc]

This should fix it:

--- a/lib/scope.js
+++ b/lib/scope.js
@@ -316,7 +316,7 @@ AST_Function.DEFMETHOD("next_mangled", function(options, def){
     var tricky_def = def.orig[0] instanceof AST_SymbolFunarg && this.name && this.name.definition();
     while (true) {
         var name = AST_Lambda.prototype.next_mangled.call(this, options, def);
-        if (!(tricky_def && tricky_def.mangled_name == name))
+        if (!tricky_def || (tricky_def.mangled_name != name && tricky_def.name != name))
             return name;
     }
 });

[michaelficarra]

This is a duplicate of #179.

[kzc]

#1202 is specific to mangle with keep_fnames=true.

By default compress and mangle use keep_fnames=false so this issue does not occur.

[kzc]

Fix: #1203

[rvanvelzen]

Fixed via eb63fec