Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buggy conditionals in 3.4.9 #3319

Closed
mortargrind opened this issue Jan 25, 2019 · 1 comment · Fixed by #3329
Closed

Buggy conditionals in 3.4.9 #3319

mortargrind opened this issue Jan 25, 2019 · 1 comment · Fixed by #3329

Comments

@mortargrind
Copy link

Bug report

Uglify version (3.4.9)

I think 3.4.9 outputs incorrect code that causes bugs when it comes to optimizing conditionals that has assignments with bracket notation and this keyword in their then/else branches. I've created a repository that demonstrates the issue. This does not happen in 3.4.8.

Here's the repo: https://github.com/mortargrind/uglify-conditionals-bug
@shaan1337
Copy link

#3314
#3309

The above two issues also probably have the same root cause.

alexlamsl added a commit to alexlamsl/UglifyJS that referenced this issue Mar 12, 2019
@alexlamsl
fix corner case in conditionals
7a95259 
fixes mishoo#3245
fixes mishoo#3257
fixes mishoo#3260
fixes mishoo#3269
fixes mishoo#3271
fixes mishoo#3278
fixes mishoo#3309
fixes mishoo#3319
fixes mishoo#3321
@alexlamsl alexlamsl mentioned this issue Mar 12, 2019
Merged
alexlamsl added a commit that referenced this issue Mar 12, 2019
@alexlamsl
fix corner case in conditionals (#3329)
008c236 
fixes #3245
fixes #3257
fixes #3260
fixes #3269
fixes #3271
fixes #3278
fixes #3309
fixes #3319
fixes #3321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix corner case in conditionals alexlamsl/UglifyJS
2 participants
@mortargrind @shaan1337