-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment inside return results in wrong code when AST gets printed #372
Comments
I just happened to stumble upon #112 The fix there doesn't fix this case, as the returnNode's value is the "||" node, whose's start doesn't have comment. Only the "||" node's left's left has comment. |
I pushed a better fix. |
rvanvelzen
pushed a commit
to rvanvelzen/UglifyJS2
that referenced
this issue
Dec 23, 2013
avdg
added a commit
to avdg/UglifyJS2
that referenced
this issue
Jan 9, 2015
alexlamsl
added a commit
to alexlamsl/UglifyJS
that referenced
this issue
Dec 21, 2017
fixes mishoo#112 fixes mishoo#218 fixes mishoo#372
alexlamsl
added a commit
to alexlamsl/UglifyJS
that referenced
this issue
Dec 21, 2017
fixes mishoo#112 fixes mishoo#218 fixes mishoo#372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Now unequal(x, y) always evaluates to undefined, since semicolon is auto added after "return" when this generated code is evaluated.
The text was updated successfully, but these errors were encountered: