Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix corner case in collapse_vars #5278

Merged
merged 1 commit into from
Jan 8, 2022
Merged

Conversation

alexlamsl
Copy link
Collaborator

fixes #5277

@alexlamsl
Copy link
Collaborator Author

@kzc in case you are keeping score, this week also sees Node.js v0.12 on GitHub Actions (ubuntu/Windows) often doing this:
https://github.com/mishoo/UglifyJS/runs/4745204864#step:4:363

Always the same three mocha tests which timed out when failiing, and while the other two might seem heavy, this one certainly shouldn't take more than 30s:

it("Should be able to filter comments correctly with `--comment <RegExp>`", function(done) {
var command = uglifyjscmd + ' test/input/comments/filter.js --comments /r/';
exec(command, function(err, stdout) {
if (err) throw err;
assert.strictEqual(stdout, "/*@preserve*/\n// bar\n");
done();
});
});

// foo
/*@preserve*/
// bar

@kzc
Copy link
Contributor

kzc commented Jan 8, 2022

That's pretty bad - two or three times slower is one thing, but --self is 30 times slower than my machine. Those machines are definitely over-provisioned.

@alexlamsl alexlamsl merged commit f473b4d into mishoo:master Jan 8, 2022
@alexlamsl alexlamsl deleted the issue-5277 branch January 8, 2022 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ufuzz failure
2 participants