Allow us to override the current_page number #137
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: I'm using will_paginate to display results from a Google custom search.
Reason: The 'total_entries' given by google is an estimate, so it's entirely possible for will_paginate to display more page numbers than actually exist. (i.e. '1 2 3' when there are only 2 pages of results). When we visit this last page, we get an accurate 'total_entries' number from google that I'd like to use to override the will_paginate page number.
This works fine for me, and all tests still pass. Let me know if you'd like it done differently, or not included in will_paginate at all. (I do plan to release the google search stuff, so it would be useful to not have to patch will_paginate).
Thanks for all the awesome work on this so far,
Alex