Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow us to override the current_page number #137

Closed
wants to merge 1 commit into from

Conversation

alexslade
Copy link

Background: I'm using will_paginate to display results from a Google custom search.

Reason: The 'total_entries' given by google is an estimate, so it's entirely possible for will_paginate to display more page numbers than actually exist. (i.e. '1 2 3' when there are only 2 pages of results). When we visit this last page, we get an accurate 'total_entries' number from google that I'd like to use to override the will_paginate page number.

This works fine for me, and all tests still pass. Let me know if you'd like it done differently, or not included in will_paginate at all. (I do plan to release the google search stuff, so it would be useful to not have to patch will_paginate).

Thanks for all the awesome work on this so far,
Alex

@mislav
Copy link
Owner

mislav commented Oct 15, 2016

Hey @heeton, sorry for the super-late reply. I think this feature is very application-specific and I don't see it being useful included in the core library. Your use-case sounds valid, but I think it would be better handled by constructing another WillPaginate::Collection object based on the first one, but with edited values as you see fit.

@mislav mislav closed this Oct 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants