Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add suppress warning option to allow rubocop to continue #97

Merged
merged 1 commit into from
Jun 9, 2019

Conversation

jtgrenz
Copy link
Contributor

@jtgrenz jtgrenz commented Apr 17, 2019

We often use a shared rubocop.yml file across multiple projects. When then parent config files is updated to include new cops but one of the consuming projects is using an older version of rubocop, rubocop will report that there are unrecognized cops. These are just warnings and shouldn't cause rubocop to fail entirely.

This PR just adds a suppress warning option to the configuration to ignore errors and run regardless. I figured anyone with a similar project configuration that often runs into issues like this might benefit from being able to toggle it on and off as they see fit.

@kevindjacobson
Copy link

My project uses Rubocop 67.0 and without this PR, I am unable to use rubocop with VScode.

@misogi
Copy link
Owner

misogi commented Jun 9, 2019

Thanks for your contribution!
It seems safe change.

@misogi misogi merged commit cffb869 into misogi:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants