Skip to content

Commit

Permalink
pythongh-113781: Silence AttributeError in warning module during Pyth…
Browse files Browse the repository at this point in the history
…on finalization (pythonGH-113813)

The tracemalloc module can already be cleared.
(cherry picked from commit 0297418)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
  • Loading branch information
serhiy-storchaka authored and miss-islington committed Jan 9, 2024
1 parent 50efd7d commit cb0d205
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
7 changes: 4 additions & 3 deletions Lib/warnings.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,16 @@ def _formatwarnmsg_impl(msg):
# catch Exception, not only ImportError and RecursionError.
except Exception:
# don't suggest to enable tracemalloc if it's not available
tracing = True
suggest_tracemalloc = False
tb = None
else:
tracing = tracemalloc.is_tracing()
try:
suggest_tracemalloc = not tracemalloc.is_tracing()
tb = tracemalloc.get_object_traceback(msg.source)
except Exception:
# When a warning is logged during Python shutdown, tracemalloc
# and the import machinery don't work anymore
suggest_tracemalloc = False
tb = None

if tb is not None:
Expand All @@ -85,7 +86,7 @@ def _formatwarnmsg_impl(msg):
if line:
line = line.strip()
s += ' %s\n' % line
elif not tracing:
elif suggest_tracemalloc:
s += (f'{category}: Enable tracemalloc to get the object '
f'allocation traceback\n')
return s
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Silence unraisable AttributeError when warnings are emitted during Python
finalization.

0 comments on commit cb0d205

Please sign in to comment.