Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🍒 Cherry Pick #452 fix for windows audio issue to 0.56 #453

Open
wants to merge 1 commit into
base: 0.56.x
Choose a base branch
from

Conversation

avanwinkle
Copy link
Collaborator

This PR cherry-picks PR #452 into 0.56 release branch to assist folks not yet ready to jump into prerelease 0.57. It bypasses the Windows circular dependency issue on importing audio libraries.

can you hear me?

@avanwinkle
Copy link
Collaborator Author

I'm a little confused about the automated tests, this PR is targeting 0.56.x but the tests are trying to install 0.57, which is failing on Python 3.7 (as expected).

@toomanybrians
Copy link
Member

There's some logic in the GitHub workflow to attempt to pull in the matching version of MPF. It's these lines:

git clone --recursive --branch ${{ github.ref_name }} https://github.com/missionpinball/mpf.git _mpf ||
git clone --recursive --branch `python get_version.py` https://github.com/missionpinball/mpf.git _mpf ||
git clone --recursive --branch dev https://github.com/missionpinball/mpf.git _mpf &&

It first tries to clone an MPF branch which matches the branch or tag name that triggered it. (Which I think for PRs include the PR number or something so prob that would fail.) If that fails the next try is using the python get_version.py which is in the root of the mpf-mc repo and looks like this:

from mpfmc._version import __short_version__
print("{}.x".format(__short_version__))

So that should print 0.56.x which is a valid MPF branch and should work. 🤷‍♂️

If that fails it gets the dev branch is what's happening here.

Looking at the logs that fail:

python: can't open file 'get_version.py': [Errno 2] No such file or directory

So, first, I wonder how long that's been failing? Maybe we never noticed since I was working in branches and not PRs. My guess is it's a path thing. It might require a ../ or mpf-mc/ first or something? You could throw a pwd into the script before that line to see where it's running from if you don't mind experimenting a bit?

@toomanybrians
Copy link
Member

Also while you're in there, you wanna re-enable the windows builds?

(The Mac ARM ones I still can't figure out even though allegedly GitHub offers Apple Silicon runners. My confusion is documented here.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants