Config player delay #1541
Merged
Config player delay #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avanwinkle
commented
Nov 16, 2020
mpf/core/utility_functions.py
Outdated
| @@ -242,7 +242,7 @@ def dict_merge(a, b, combine_lists=True) -> dict: | |||
| elif k in result and isinstance(result[k], dict): | |||
| result[k] = Util.dict_merge(result[k], v, combine_lists) | |||
| elif k in result and isinstance(result[k], list): | |||
| if isinstance(v, dict) and v[0] == dict(_overwrite=True): | |||
| if isinstance(v, list) and v[0] == dict(_overwrite=True): | |||
There was a problem hiding this comment.
I don't remember what situation I was in that kept crashing on this error, but attempting to access v[0] when v is a dict... seems like just a typo. If I'm overlooking something here, please let me know!
|
I reverted my change to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new settings option to all ConfigPlayer-based classes:
delay.When provided, the
delayoption will schedule the play event to be posted some time in the future. The implementation does not currently support cancelling delayed events.Note: the delay is not automatic for all ConfigPlayers. Instead, a ConfigPlayer class may choose to call
self.check_delayed_play()as part of its play handler, as is done here missionpinball/mpf-mc#409 for SoundPlayer. Other players may follow suit, as needed.This PR also has some minor bugfixes and tweaks:
colorsetting to allow RGB flashers to flash in colorThis last one is an edge case, but one I've been fighting. When a shot changes state, it posts the name of the new state and the old state. If custom python code has changed the profile of the shot and the new profile doesn't have as many states, and the shot was previously in a state higher than the number in the new profile, the attempt to fetch the old name would throw an exception. This PR gracefully handles that exception and just posts "unknown" as the old state name.