perf(frontend): use setInterval instead of setTimeout chain in MkTime #10981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #10981 +/- ##
===========================================
- Coverage 77.36% 77.33% -0.03%
===========================================
Files 908 907 -1
Lines 91588 91495 -93
Branches 7547 7550 +3
===========================================
- Hits 70856 70761 -95
- Misses 20732 20734 +2
|
acid-chicken
reviewed
Jun 9, 2023
acid-chicken
approved these changes
Jun 9, 2023
syuilo
reviewed
Jun 10, 2023
|
今は無駄な更新を避けるため時間が経過しているほど更新の頻度が少なくなるようになってるけど、このPRで更新間隔が一律になるから全体的にパフォーマンス改善するかは微妙かも |
|
Safariだとバックグラウンド状態から復帰した場合の動きがマシになった気がする（気がするだけかも） |
|
今のままでもrequestAnimationFrameとか使えば改善しないかな |
|
（なんとなく変な手を加えずにsetIntervalしたほうがいい気がするんだよな…） |
|
今の方式を踏襲しつつsetIntervalにするか |
|
setIntervalにしてみた |
slofp
pushed a commit
to Secineralyr/misskey.dream
that referenced
this pull request
Jul 21, 2023
misskey-dev#10981) * perf(frontend): use setInterval instead of setTimeout chain in MkTime * fix * props.origin * props.origin 2 * fix * add comment * setIntervalを再設定する * refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
MkTimeでは、setTimeoutをチェーンするのではなくsetInterval(10*1000)を回し続けるようにする
Why
特にスリープから復帰した際のパフォーマンス向上?
Additional info (optional)
p1.a9z.devで動作中
Checklist