Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): GTLの「リノートを表示」オプションが機能しないのを修正 #12234

Merged
merged 3 commits into from
Nov 4, 2023

Conversation

ozelotdev
Copy link
Contributor

@ozelotdev ozelotdev commented Nov 3, 2023

What

GTLで過去の投稿を閲覧するとき、「リノートを表示」がオフでも、他人のリノートが表示されるようにします。
(Stream側は実装済みのため、Endpoint側のみの修正です)

Why

Fix #12233

Additional info (optional)

  • パフォーマンスを理由にGTL自体が廃止されかけたので、パフォーマンスが悪化しないかは注意が必要です。
  • (とはいえ、そこまで重たい処理をしている訳では無いので、大丈夫じゃないかなとは思っています)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 3, 2023
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (a8e976d) 78.86% compared to head (dd0c32c) 78.81%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12234      +/-   ##
===========================================
- Coverage    78.86%   78.81%   -0.06%     
===========================================
  Files          946      944       -2     
  Lines       101933   101772     -161     
  Branches      8239     8232       -7     
===========================================
- Hits         80393    80210     -183     
- Misses       21540    21562      +22     
Files Coverage Δ
.../src/server/api/endpoints/notes/global-timeline.ts 58.40% <0.00%> (-5.68%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 3, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@ozelotdev ozelotdev marked this pull request as ready for review November 3, 2023 16:10
Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
@ozelotdev ozelotdev changed the title fix(backend): GTLの「リノートを表示」オプションが機能しないのを修正 (#12233) fix(backend): GTLの「リノートを表示」オプションが機能しないのを修正 Nov 4, 2023
@syuilo syuilo merged commit 1e737db into misskey-dev:develop Nov 4, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 4, 2023

🙏🏻

@ozelotdev ozelotdev deleted the fix/12233 branch November 4, 2023 09:46
kanarikanaru pushed a commit to kanarikanaru/misskey that referenced this pull request Nov 9, 2023
* fix(backend): GTLの「リノートを表示」オプションが機能しないのを修正 (misskey-dev#12233)

* docs: Update changelog

* Apply suggestions from code review

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>

---------

Co-authored-by: syuilo <Syuilotan@yahoo.co.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GTLで過去の投稿を閲覧するとき「リノートを表示」オプションが機能していない
2 participants