Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test break caused by #12273 #12322

Merged
merged 2 commits into from
Nov 13, 2023

Conversation

Candinya
Copy link
Contributor

@Candinya Candinya commented Nov 13, 2023

What

fix: test break caused by #12273

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31174d6) 78.85% compared to head (d2d0f12) 78.87%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12322      +/-   ##
===========================================
+ Coverage    78.85%   78.87%   +0.02%     
===========================================
  Files          944      946       +2     
  Lines       101886   102056     +170     
  Branches      8242     8236       -6     
===========================================
+ Hits         80339    80495     +156     
- Misses       21547    21561      +14     
Files Coverage Δ
packages/frontend/src/config.ts 92.59% <100.00%> (ø)
packages/frontend/src/stream.ts 76.66% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 13, 2023

このPRによるapi.jsonの差分

差分はこちら

Get diff files from Workflow Page

@Candinya Candinya marked this pull request as ready for review November 13, 2023 06:39
@Candinya Candinya mentioned this pull request Nov 13, 2023
5 tasks
@syuilo syuilo merged commit 1361bdf into misskey-dev:develop Nov 13, 2023
18 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 13, 2023

🙏🏻

@Candinya Candinya deleted the fix/api-url-caused-test-fail branch November 13, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants