Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: running from docker is broken #12824

Merged
merged 4 commits into from
Dec 27, 2023

Conversation

anatawa12
Copy link
Member

@anatawa12 anatawa12 commented Dec 27, 2023

What

Fixes #12822

misskey-jsのビルド済バイナリ(js)がpackages/misskey-js/builtになかったせいで落ちてたのでコピーするようにした

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@anatawa12
Copy link
Member Author

今修正の動作確認中 @ local

Copy link

codecov bot commented Dec 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8261a1) 79.95% compared to head (9345f2e) 79.94%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12824      +/-   ##
===========================================
- Coverage    79.95%   79.94%   -0.01%     
===========================================
  Files          956      955       -1     
  Lines       108864   108800      -64     
  Branches      8413     8413              
===========================================
- Hits         87045    86984      -61     
+ Misses       21819    21816       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anatawa12
Copy link
Member Author

治ってなかった


> misskey@2023.12.1 start /misskey
> pnpm check:connect && cd packages/backend && node ./built/boot/entry.js


> misskey@2023.12.1 check:connect /misskey
> cd packages/backend && pnpm check:connect


> backend@ check:connect /misskey/packages/backend
> node ./check_connect.js

node:internal/modules/cjs/loader:1144
  const err = new Error(message);
              ^

Error: Cannot find module 'eventemitter3'
Require stack:
- /misskey/packages/misskey-js/built/streaming.js
- /misskey/packages/misskey-js/built/index.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1144:15)
    at Module._load (node:internal/modules/cjs/loader:985:27)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at require (node:internal/modules/helpers:176:18)
    at Object.<anonymous> (/misskey/packages/misskey-js/built/streaming.js:7:25)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1435:10)
    at Module.load (node:internal/modules/cjs/loader:1207:32)
    at Module._load (node:internal/modules/cjs/loader:1023:12)
    at Module.require (node:internal/modules/cjs/loader:1235:19) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/misskey/packages/misskey-js/built/streaming.js',
    '/misskey/packages/misskey-js/built/index.js'
  ]
}

@anatawa12
Copy link
Member Author

--- ebd8e581ce7b (PID: 178) ---
INFO *  [core boot]     Welcome to Misskey!
INFO *  [core boot]     Misskey v2023.12.1
INFO *  [core boot env] NODE_ENV: production
INFO *  [core boot nodejs]      Version v20.10.0 detected.
DONE *  [core boot config]      Loaded
DONE *  [core boot]     Misskey initialized
INFO *  [core nest]     NestFactory: Starting Nest application...
INFO *  [core nest]     InstanceLoader: MainModule dependencies initialized
INFO *  [core nest]     InstanceLoader: QueueModule dependencies initialized
INFO *  [core nest]     InstanceLoader: GlobalModule dependencies initialized
INFO *  [core nest]     InstanceLoader: RepositoryModule dependencies initialized
INFO *  [core nest]     InstanceLoader: DaemonModule dependencies initialized
INFO *  [core nest]     InstanceLoader: ServerModule dependencies initialized
INFO *  [core nest]     InstanceLoader: EndpointsModule dependencies initialized
INFO *  [core nest]     InstanceLoader: CoreModule dependencies initialized
INFO *  [core boot]     Starting 1 worker...
INFO 1  [core nest]     NestFactory: Starting Nest application...
INFO 1  [core nest]     InstanceLoader: QueueModule dependencies initialized
INFO 1  [core nest]     InstanceLoader: GlobalModule dependencies initialized
INFO 1  [core nest]     InstanceLoader: RepositoryModule dependencies initialized
INFO 1  [core nest]     InstanceLoader: CoreModule dependencies initialized
INFO 1  [core nest]     InstanceLoader: QueueProcessorModule dependencies initialized
DONE *  [core boot]     All workers started
DONE *  [core boot]     Now listening on port 3000 on http://localhost:3000
INFO 1  [queue check-expired-mutings]   Checking expired mutings...
DONE 1  [queue check-expired-mutings]   All expired mutings checked.

まで動作確認しました

@anatawa12 anatawa12 marked this pull request as ready for review December 27, 2023 14:53
@kakkokari-gtyih
Copy link
Contributor

@misskey-dev/dev

@anatawa12
Copy link
Member Author

CHANGELOG忘れてた今から書きます

@anatawa12
Copy link
Member Author

DONE

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com>
@syuilo syuilo merged commit 8753f9e into misskey-dev:develop Dec 27, 2023
15 checks passed
@syuilo
Copy link
Member

syuilo commented Dec 27, 2023

🙏

camilla-ett pushed a commit to kaseiski/misskey that referenced this pull request Jan 2, 2024
* fix: running from docker is broken

* fix: dependencies of misskey-js not found from backend

* docs(changelog): Dockerでサーバーを起動できない問題を修正

* Update CHANGELOG.md

Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com>

---------

Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com>
madonuko pushed a commit to FyraLabs/nyaakey that referenced this pull request Feb 26, 2024
* fix: running from docker is broken

* fix: dependencies of misskey-js not found from backend

* docs(changelog): Dockerでサーバーを起動できない問題を修正

* Update CHANGELOG.md

Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com>

---------

Co-authored-by: かっこかり <67428053+kakkokari-gtyih@users.noreply.github.com>
@anatawa12 anatawa12 deleted the fix-docker-build-failure branch March 10, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker使用時にエラー吐いて落ちる
3 participants